Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

[Ingo Molnar]

* Mathieu Malaterre <malat@xxxxxxxxxx> wrote:

> Hi Ingo,
> 
> On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> > * Mathieu Malaterre <malat@xxxxxxxxxx> wrote:
> >
> >> Fix non-fatal warnings such as:
> >>
> >> kernel/events/ring_buffer.c:116:1: warning: âinlineâ is not at beginning of declaration [-Wold-style-declaration]
> >>  static int __always_inline
> >>  ^~~~~~
> >>
> >> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
> >> ---
> >>  kernel/events/ring_buffer.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Hm, never saw this warning before - is this a newly default GCC warning, or some
> > distro CFLAGS build that enables it?
> 
> Nope. Just compiling vanilla kernel with default options, defconfig
> was pmac32. I used W=1.

"W=1" is not a default build variant - it enables -Wall...

This absolutely needs to be spelled out in the changelog!

Thanks,

	Ingo