Re: [PATCH v2] iio: adc: max9611: fix module auto-loading

[Andy Shevchenko]

On Fri, Dec 29, 2017 at 3:59 PM, Dmitry Mastykin <mastichi@xxxxxxxxx> wrote:
> The simplest fix is to move to ->probe_new() since the driver is not
> used out of DT/ACPI enumeration.
>

Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

I suppose, and

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Thanks!

> Signed-off-by: Dmitry Mastykin <mastichi@xxxxxxxxx>
> ---
>  drivers/iio/adc/max9611.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
> index b1dd17c..ce0115a 100644
> --- a/drivers/iio/adc/max9611.c
> +++ b/drivers/iio/adc/max9611.c
> @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = {
>  };
>
>  MODULE_DEVICE_TABLE(of, max9611_of_table);
> -static int max9611_probe(struct i2c_client *client,
> -                        const struct i2c_device_id *id)
> +static int max9611_probe(struct i2c_client *client)
>  {
>         const char * const shunt_res_prop = "shunt-resistor-micro-ohms";
>         const struct device_node *of_node = client->dev.of_node;
> @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = {
>                    .owner = THIS_MODULE,
>                    .of_match_table = max9611_of_table,
>         },
> -       .probe = max9611_probe,
> +       .probe_new = max9611_probe,
>  };
>  module_i2c_driver(max9611_driver);
>
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko