Re: [PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP

[Philippe Ombredanne]

On Sat, Dec 30, 2017 at 9:41 PM, Eric Leblond <eric@xxxxxxxxx> wrote:
> Parse netlink ext attribute to get the error message returned by
> the card. Code is partially take from libnl.
>
> Signed-off-by: Eric Leblond <eric@xxxxxxxxx>
> Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>

<snip>

> --- /dev/null
> +++ b/tools/lib/bpf/nlattr.c
> @@ -0,0 +1,187 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +
> +/*
> + * NETLINK      Netlink attributes
> + *
> + *     This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU Lesser General Public
> + *     License as published by the Free Software Foundation version 2.1
> + *     of the License.
> + *
> + * Copyright (c) 2003-2013 Thomas Graf <tgraf@xxxxxxx>
> + */

Do you think you could get an ack or signoff from the author
(i.e.Thomas Graf)  to get a more streamlined thing such as this:

> +// SPDX-License-Identifier: LGPL-2.1
> +// NETLINK      Netlink attributes
> +// Copyright (c) 2003-2013 Thomas Graf <tgraf@xxxxxxx>


-- 
Cordially
Philippe Ombredanne