Re: [PATCH] x86: clean up confusing x86_mask

From: kbuild test robot
Date: Sun Dec 31 2017 - 06:45:12 EST


Hi Jia,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.15-rc5]
[also build test ERROR on next-20171222]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Jia-Zhang/x86-clean-up-confusing-x86_mask/20171231-182946
config: i386-randconfig-a0-201753 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers//hwmon/hwmon-vid.c: In function 'vid_which_vrm':
>> drivers//hwmon/hwmon-vid.c:296:44: error: 'struct cpuinfo_x86' has no member named 'x86_mask'
vrm_ret = find_vrm(c->x86, c->x86_model, c->x86_mask, c->x86_vendor);
^

vim +296 drivers//hwmon/hwmon-vid.c

^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 287
734a12a3 drivers/hwmon/hwmon-vid.c Rudolf Marek 2005-12-18 288 u8 vid_which_vrm(void)
^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 289 {
92cb7612 drivers/hwmon/hwmon-vid.c Mike Travis 2007-10-19 290 struct cpuinfo_x86 *c = &cpu_data(0);
3230f704 drivers/hwmon/hwmon-vid.c Guenter Roeck 2012-01-24 291 u8 vrm_ret;
^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 292
da97a5a3 drivers/hwmon/hwmon-vid.c Jean Delvare 2005-07-31 293 if (c->x86 < 6) /* Any CPU with family lower than 6 */
3230f704 drivers/hwmon/hwmon-vid.c Guenter Roeck 2012-01-24 294 return 0; /* doesn't have VID */
3230f704 drivers/hwmon/hwmon-vid.c Guenter Roeck 2012-01-24 295
3230f704 drivers/hwmon/hwmon-vid.c Guenter Roeck 2012-01-24 @296 vrm_ret = find_vrm(c->x86, c->x86_model, c->x86_mask, c->x86_vendor);
0a88f4b5 drivers/hwmon/hwmon-vid.c Jean Delvare 2011-07-25 297 if (vrm_ret == 134)
0a88f4b5 drivers/hwmon/hwmon-vid.c Jean Delvare 2011-07-25 298 vrm_ret = get_via_model_d_vrm();
^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 299 if (vrm_ret == 0)
1f923c7a drivers/hwmon/hwmon-vid.c Joe Perches 2010-10-20 300 pr_info("Unknown VRM version of your x86 CPU\n");
^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 301 return vrm_ret;
^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 302 }
^1da177e drivers/i2c/i2c-sensor-vid.c Linus Torvalds 2005-04-16 303

:::::: The code at line 296 was first introduced by commit
:::::: 3230f7049e6325c27d6d40f2a1547cf75bc4ddff hwmon: (hwmon-vid) Add new entries to VRM model table

:::::: TO: Guenter Roeck <linux@xxxxxxxxxxxx>
:::::: CC: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip