Re: [PATCH] crypto: Use zeroing memory allocator instead of allocator/memset
From: Julia Lawall
Date: Sun Dec 31 2017 - 12:10:29 EST
On Sun, 31 Dec 2017, Himanshu Jha wrote:
> On Sun, Dec 31, 2017 at 07:46:09AM -0800, Joe Perches wrote:
> > On Sun, 2017-12-31 at 17:54 +0530, Himanshu Jha wrote:
> > > Use dma_zalloc_coherent for allocating zeroed
> > > memory and remove unnecessary memset function.
> > >
> > > Done using Coccinelle.
> > > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> > I thought you were going to change this tag to
> > not use the "-by:" form and use something else
> > like "generated-using:" or "created-with:".
> Thanks for pointing that out!
> I was going to ask this to Julia for the appropriate tag, but it slipped
> my mind. In future I will definitely choose more appropriate tag
> on the Coccinelle patches.
> Just to give an insight of the problem to everyone :
> While running checkpatch on patches involving the above Generated-by
> tag, which is generally used to specify the cocci script used,
> checkpatch prompts the below warning and error :
> WARNING: Non-standard signature: Generated-by:
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> ERROR: Unrecognized email address:
> Joe suggested to not use the "-by:" form since it should be reserved
> for actual people's names and email addresses.
> And if you use other tag than the "-by:" tag, then there is no
> error/warning produced.
kbuild uses eg
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Himanshu Jha