Re: [PATCH 1/2] MIPS: add declaration for function `memory_region_available`

[James Hogan]

On Tue, Dec 26, 2017 at 12:37:13PM +0100, Mathieu Malaterre wrote:
> Fix non-fatal warning:
> 
> arch/mips/kernel/setup.c:158:13: warning: no previous prototype for âmemory_region_availableâ [-Wmissing-prototypes]
>  bool __init memory_region_available(phys_addr_t start, phys_addr_t size)
>              ^~~~~~~~~~~~~~~~~~~~~~~

It only seems to be referenced from that one file, so making it static
and __maybe_unused to handle the configs it isn't used would probably be
better.

Thanks
James

> 
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
> ---
>  arch/mips/include/asm/bootinfo.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
> index e26a093bb17a..32e3c9a2c5a0 100644
> --- a/arch/mips/include/asm/bootinfo.h
> +++ b/arch/mips/include/asm/bootinfo.h
> @@ -108,6 +108,7 @@ extern struct boot_mem_map boot_mem_map;
>  
>  extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);
>  extern void detect_memory_region(phys_addr_t start, phys_addr_t sz_min,  phys_addr_t sz_max);
> +extern bool memory_region_available(phys_addr_t start, phys_addr_t size);
>  
>  extern void prom_init(void);
>  extern void prom_free_prom_memory(void);
> -- 
> 2.11.0
> 
>

Attachment: signature.asc
Description: Digital signature