Re: [PATCH V4 24/26] video: fbdev: riva: deprecate pci_get_bus_and_slot()

From: Sinan Kaya
Date: Tue Jan 02 2018 - 08:37:43 EST


On 12/19/2017 12:38 AM, Sinan Kaya wrote:
> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
> where a PCI device is present. This restricts the device drivers to be
> reused for other domain numbers.
>
> Getting ready to remove pci_get_bus_and_slot() function in favor of
> pci_get_domain_bus_and_slot().
>
> struct riva_par has a pointer to struct pci_dev. Use the pci_dev member
> to extract the domain information.
>
> Change the function signature for CalcStateExt and RivaGetConfig to pass
> in struct pci_dev in addition to RIVA_HW_INST so that code inside the
> riva_hw.c can also calculate domain number and pass it to
> pci_get_domain_bus_and_slot().
>
> Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx>

Any feedback here, most of the remaining patches have the ACK except these?

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.