Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

[Geert Uytterhoeven]

Hi Ulf,

On Tue, Jan 2, 2018 at 2:02 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>>> [Ulf: Converted to use the WAKEUP_PATH driver PM flag]
>>
>> Ulf: + killing the DEV_PM_OPS define, increasing kernel size if PM_SUSPEND=n?
>
> Oh, yes - correct!
>
> The code looks nicer, with the penalty of one static struct declared
> and not used, in case CONFIG_PM_SLEEP is unset.

At 23 pointers of 4 or 8 bytes each in 3 drivers, I don't consider this
insignificant.

Fortunately this driver is not used on RZ/A1, which you can run without
external RAM if you manage to fit everything in 10 MiB of SRAM...

> Should I revert back to your proposal, I am fine with whatever?

Yes please.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds