Re: [PATCH] xen/input: do not advertise multi-touch pressure support

From: Dmitry Torokhov
Date: Tue Jan 02 2018 - 12:40:04 EST


On Tue, Jan 02, 2018 at 10:12:55AM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> Some user-space applications expect multi-touch pressure
> on contact to be reported if it is advertised in device
> properties. Otherwise, such applications may treat reports
> not as actual touches, but hovering. Currently this is
> only advertised, but not reported.
> Fix this by not advertising that ABS_MT_PRESSURE is supported.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@xxxxxxxx>

Applied, thank you.

> ---
> drivers/input/misc/xen-kbdfront.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 6bf56bb5f8d9..d91f3b1c5375 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
> 0, width, 0, 0);
> input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
> 0, height, 0, 0);
> - input_set_abs_params(mtouch, ABS_MT_PRESSURE,
> - 0, 255, 0, 0);
>
> ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
> if (ret) {
> --
> 2.7.4
>

--
Dmitry