Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency

From: Sinan Kaya
Date: Tue Jan 02 2018 - 13:19:57 EST


On 1/2/2018 1:10 PM, Randy Dunlap wrote:
>>> config ACPI_I2C_OPREGION
>>> bool "ACPI I2C Operation region support"
>>> - depends on I2C=y && ACPI
>>> + depends on I2C && ACPI
>>> default y
>>> help
>>> Say Y here if you want to enable ACPI I2C operation region support.
>>>
>> Anybody picking this up?
> Well. It looks to me like the patch is reversed or the patch description
> needs some improvement. Or I just don't understand it.

I'll let Eric improve the description.

Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected.
Therefore, any ACPI opregion calls targeting I2C fail with no opregion found.

The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.