Re: [PATCH v2 4/6] clk: ingenic: Add JZ47xx TCU clocks driver

[Stephen Boyd]

On 01/02, Paul Cercueil wrote:
> >> +		goto err_free_tcu;
> >> +	}
> >> +
> >> +	tcu->clocks.clk_num = nb_clks;
> >> +	tcu->clocks.clks = kcalloc(nb_clks, sizeof(struct clk *),
> >>GFP_KERNEL);
> >> +	if (!tcu->clocks.clks) {
> >> +		pr_err("%s: cannot allocate memory\n", __func__);
> >
> >We don't need allocation error messages. Please run checkpatch.
> 
> I did run checkpatch, which warned about this, but that's a false
> positive to me.
> The callback passed to CLK_OF_DECLARE() has a return type void, so
> there's no
> way I can return -ENOMEM, and I don't want the error to be unnoticed.

The kernel typically spews a bunch of information when an
allocation error happens, so your pr_err() will be lost in the
spew, which is why it's not really necessary.

> 
> About the other remarks - I agree with you, I'll fix these in the V2.
> 

Ok.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project