Re: [PATCH v3 18/27] pinctrl: replace devm_ioremap_nocache with devm_ioremap

From: Yisheng Xie
Date: Wed Jan 03 2018 - 01:16:00 EST




On 2018/1/2 16:43, Linus Walleij wrote:
> On Sat, Dec 23, 2017 at 12:00 PM, Yisheng Xie <xieyisheng1@xxxxxxxxxx> wrote:
>
>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> function with devm_ioremap_nocache, which can just be killed to
>> save the size of devres.o
>>
>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>> which should not have any function change but prepare for killing
>> devm_ioremap_nocache.
>>
>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Cc: linux-gpio@xxxxxxxxxxxxxxx
>> Signed-off-by: Yisheng Xie <xieyisheng1@xxxxxxxxxx>
>
> Patch applied.

Well, I list the ARCHs related to the change file, do not include cris,ia64,mn10300
and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in cover
letter. So please let me know if I need update the comment.

change file ARCH
drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 +- arm/arm64
drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 4 ++-- arm
drivers/pinctrl/freescale/pinctrl-imx1-core.c | 2 +- arm
drivers/pinctrl/pinctrl-amd.c | 4 ++-- x86/arm

Thanks
Yisheng
>
> Yours,
> Linus Walleij
>
>