Re: [PATCH] bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr()

[Mahesh Bandewar (àààà ààààààà)]

On Mon, Jan 1, 2018 at 8:07 AM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 1 Jan 2018 17:00:04 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
What is the issue with this message?

> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/bonding/bond_main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index c669554d70bb..a96e0c9cc4bf 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3910,7 +3910,6 @@ int bond_update_slave_arr(struct bonding *bond, struct slave *skipslave)
>                           GFP_KERNEL);
>         if (!new_arr) {
>                 ret = -ENOMEM;
> -               pr_err("Failed to build slave-array.\n");
>                 goto out;
>         }
>         if (BOND_MODE(bond) == BOND_MODE_8023AD) {
> --
> 2.15.1
>