Re: [PATCH 2/4] extcon: axp288: Remove unused platform data

[Lee Jones]

On Wed, 03 Jan 2018, Chanwoo Choi wrote:

> Dear Lee,
> 
> On 2018ë 01ì 02ì 18:16, Lee Jones wrote:
> > On Tue, 02 Jan 2018, Chanwoo Choi wrote:
> > 
> >> + MFD Maintainer (Lee Jones <lee.jones@xxxxxxxxxx>)
> >>
> >> Hi Hans,
> >>
> >> You better to use the scripts/get_maintainer.pl for the mailing list.
> >> I added the MFD maintainer.
> >>
> >> This patch looks good to me.
> >> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> >>
> >>
> >> Best Regards,
> >> Chanwoo Choi
> >>
> >> On 2017ë 12ì 22ì 21:36, Hans de Goede wrote:
> >>> This is not used / set anywhere in the tree.
> >>>
> >>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >>> ---
> >>>  drivers/extcon/extcon-axp288.c | 35 +----------------------------------
> >>>  include/linux/mfd/axp20x.h     |  5 -----
> > 
> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > 
> 
> I already made the immutable branch[1] for both mfd and extcon.
> [1] https://lkml.org/lkml/2017/12/15/133
> 
> I added the additional patch for 'include/linux/mfd/axp20x.h'
> If you want to need to apply it on mfd tree, please apply them of immutable branch.
> 
> 
> The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:
> 
>   Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git ib-extcon-mfd-4.16

How is this possible?  ib-extcon-mfd-4.16 is already immutable.

I believe you should have created a new tag:

  ib-extcon-mfd-4.16-1

... based on ib-extcon-mfd-4.16.

> for you to fetch changes up to 9bf317e900a19a857eb9921c9441a92e89f40415:
> 
>   extcon: axp288: Remove unused platform data (2018-01-03 10:11:02 +0900)
> 
> ----------------------------------------------------------------
> Arvind Yadav (1):
>       extcon: axp288:: Handle return value of platform_get_irq
> 
> Benson Leung (1):
>       extcon: usbc-cros-ec: add support to notify USB type cables.
> 
> Hans de Goede (2):
>       extcon: axp288: Remove unused extcon_nb struct member
>       extcon: axp288: Remove unused platform data
> 
>  drivers/extcon/extcon-axp288.c       |  39 +---------
>  drivers/extcon/extcon-usbc-cros-ec.c | 142 ++++++++++++++++++++++++++++++++++-
>  include/linux/mfd/axp20x.h           |   5 --
>  include/linux/mfd/cros_ec_commands.h |  17 +++++
>  4 files changed, 159 insertions(+), 44 deletions(-)
> 

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog