Re: [PATCH] ASoC: max98373: Added Amplifier Driver

From: Mark Brown
Date: Wed Jan 03 2018 - 11:58:08 EST


On Mon, Dec 25, 2017 at 11:17:29PM +0000, Kuninori Morimoto wrote:

> Having private regmap seems a little bit duplicate for me,
> because we can get it from component or dev.
> But sometimes, in some drivers, it seems can be difficult.
> Sorry for my noise.

It is duplication but if you've only got the dev then it makes things a
bit faster as the call to look up a regmap from a dev is relatively
expensive. That's not the case for components though where it's just a
straight variable lookup so it's more a case of how clean the code looks
and preference there.

Attachment: signature.asc
Description: PGP signature