Re: [PATCH v2] ARM: dts: imx6: RDU2: disable internal watchdog

From: Andrey Smirnov
Date: Wed Jan 03 2018 - 12:05:00 EST


On Mon, Jan 1, 2018 at 1:50 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> Hi Andrey,
>
> On Mon, Jan 1, 2018 at 7:24 PM, Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:
>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 6bef9a98678e..818bfc8692a5 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -838,6 +838,10 @@
>> status = "okay";
>> };
>>
>> +&wdog1 {
>> + status = "disabled";
>> +};
>> +
>> &audmux {
>
> We should keep the nodes in alphabetical order. Other than that:
>
> Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>

It seems that with exception of "audmux" and "iomuxc" the nodes are in
alphabetical order (and I suspect "audmux" falls under the same
exception "iomuxc" does?). What did you have in mind for that node?
Placing it after "audmux"?

Thanks,
Andrey Smirnov