Re: [PATCH v5 3/7] scsi: libsas: make the event threshold configurable

[John Garry]

On 15/12/2017 12:19, Hannes Reinecke wrote:
> On 12/08/2017 10:42 AM, Jason Yan wrote:
> > Add a sysfs attr that LLDD can configure it for every host. We made
> > a example in hisi_sas. Other LLDDs using libsas can implement it if
> > they want.
> >
> > Suggested-by: Hannes Reinecke <hare@xxxxxxxx>
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > CC: John Garry <john.garry@xxxxxxxxxx>
> > CC: Johannes Thumshirn <jthumshirn@xxxxxxx>
> > CC: Ewan Milne <emilne@xxxxxxxxxx>
> > CC: Christoph Hellwig <hch@xxxxxx>
> > CC: Tomas Henzl <thenzl@xxxxxxxxxx>
> > CC: Dan Williams <dan.j.williams@xxxxxxxxx>
> > ---
> >  drivers/scsi/hisi_sas/hisi_sas_main.c |  6 ++++++
> >  drivers/scsi/libsas/sas_init.c        | 31 +++++++++++++++++++++++++++++++
> >  include/scsi/libsas.h                 |  1 +
> >  3 files changed, 38 insertions(+)
> Ah, here is it now.
> So ignore that part of my previous comment.

Hi Hannes,

Thanks for checking this.

Can you please re-review "[PATCH v5 2/7] scsi: libsas: shut down the PHY 
if events reached the threshold" to see if you are happy with it? We 
have no tag currently.

Very much appreciated,
John

> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
>
> Cheers,
>
> Hannes