Re: [PATCH v4 5/7] clk: Introduce davinci clocks

[David Lechner]

On 1/4/18 6:43 AM, Sekhar Nori wrote:
> Hi David,
>
> On Monday 01 January 2018 05:09 AM, David Lechner wrote:
> > +	/* TODO: old davinci clocks for da850 set MDCTL_FORCE bit for sata and
> > +	 * dsp here. Is this really needed?
> > +	 */
>
> The commit that introduced this flag suggests so.
>
> commit aad70de20fc69970a3080e7e8f02b54a4a3fe3e6
> Author:     Sekhar Nori <nsekhar@xxxxxx>
> AuthorDate: Wed Jul 6 06:01:22 2011 +0000
> Commit:     Sekhar Nori <nsekhar@xxxxxx>
> CommitDate: Fri Jul 8 11:10:09 2011 +0530
>
>      davinci: enable forced transitions on PSC
>
>      Some DaVinci modules like the SATA on DA850
>      need forced module state transitions.
>
>      Define a "force" flag which can be passed to
>      the PSC config function to enable it to make
>      forced transitions.
>
>      Forced transitions shouldn't normally be attempted,
>      unless the TRM explicitly specifies its usage.
>
>      ChangeLog:
>      v2:
>      Modified to take care of the fact that
>      davinci_psc_config() now takes the flags
>      directly.
>
>      Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
>
> I can check without that flag again, but I do recall it being needed.

OK, I will add it back. I need to add some other flags as well anyway.