Re: [PATCH net] net: stmmac: enable EEE in MII, GMII or RGMII only

From: David Miller
Date: Thu Jan 04 2018 - 14:02:36 EST


From: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
Date: Wed, 3 Jan 2018 16:46:29 +0100

> Note in the databook - Section 4.4 - EEE :
> " The EEE feature is not supported when the MAC is configured to use the
> TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC
> supports multiple PHY interfaces, you should activate the EEE mode only
> when the MAC is operating with GMII, MII, or RGMII interface."
>
> Applying this restriction solves a stability issue observed on Amlogic
> gxl platforms operating with RMII interface and the internal PHY.
>
> Fixes: 83bf79b6bb64 ("stmmac: disable at run-time the EEE if not supported")
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> Tested-by: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>

Applied and queued up for -stable, thanks.