Re: [PATCH v3 6/9] media: i2c: ov772x: Remove soc_camera dependencies

From: Laurent Pinchart
Date: Thu Jan 04 2018 - 17:20:30 EST


Hi Jacopo,

Thank you for the patch.

On Thursday, 4 January 2018 18:03:14 EET Jacopo Mondi wrote:
> Remove soc_camera framework dependencies from ov772x sensor driver.
> - Handle clock and gpios
> - Register async subdevice
> - Remove soc_camera specific g/s_mbus_config operations
> - Change image format colorspace from JPEG to SRGB as the two use the
> same colorspace information but JPEG makes assumptions on color
> components quantization that do not apply to the sensor
> - Remove sizes crop from get_selection as driver can't scale
> - Add kernel doc to driver interface header file
> - Adjust build system
>
> This commit does not remove the original soc_camera based driver as long
> as other platforms depends on soc_camera-based CEU driver.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/media/i2c/Kconfig | 11 +++
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov772x.c | 177 +++++++++++++++++++++++++++---------------
> include/media/i2c/ov772x.h | 6 +-
> 4 files changed, 133 insertions(+), 62 deletions(-)

--
Regards,

Laurent Pinchart