Re: [rdma for-next] bnxt_re: report RoCE device support at info level

From: Devesh Sharma
Date: Fri Jan 05 2018 - 04:52:52 EST


Acked-By: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx>

On Fri, Jan 5, 2018 at 2:34 AM, Jonathan Toppins <jtoppins@xxxxxxxxxx> wrote:
> Reporting that a device doesn't support RoCE seems like a valuable piece
> of information to have when trying to determine why a driver is not binding
> to a device. Better to report this at info log level instead of requiring
> a user to enable all debug messages in the driver.
>
> Signed-off-by: Jonathan Toppins <jtoppins@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/bnxt_re/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index aafc19aa5de1..bf268bf1f496 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -417,7 +417,7 @@ static struct bnxt_en_dev *bnxt_re_dev_probe(struct net_device *netdev)
> return ERR_PTR(-EINVAL);
>
> if (!(en_dev->flags & BNXT_EN_FLAG_ROCE_CAP)) {
> - dev_dbg(&pdev->dev,
> + dev_info(&pdev->dev,
> "%s: probe error: RoCE is not supported on this device",
> ROCE_DRV_MODULE_NAME);
> return ERR_PTR(-ENODEV);
> --
> 2.13.6
>