Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all

[Daniel Thompson]

On 09/12/17 16:27, Vincent Legoll wrote:
> No need to get into the submenu to disable all related
> config entries.
>
> This makes it easier to disable all RUNTIME_TESTS config options
> without entering the submenu. It will also enable one to see that
> en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.

Wouldn't you need a "default y" applied to the menuconfig to achieve this?

With this patch applied defconfigs that enable LKDTM by default will no 
longer do so (default_defconfig from arch/s390 is an example although 
there are others).


Daniel.


> Signed-off-by: Vincent Legoll <vincent.legoll@xxxxxxxxx>
> ---
>   lib/Kconfig.debug | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 947d3e2ed5c2..9436714254b7 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
>   
>   	  If unsure, say N.
>   
> -menu "Runtime Testing"
> +menuconfig RUNTIME_TESTING_MENU
> +	bool "Runtime Testing"
> +
> +if RUNTIME_TESTING_MENU
>   
>   config LKDTM
>   	tristate "Linux Kernel Dump Test Tool Module"
> @@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
>   
>   	  If unsure, say N.
>   
> -endmenu # runtime tests
> +endif # RUNTIME_TESTING_MENU
>   
>   config MEMTEST
>   	bool "Memtest"