Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

[Mark Brown]

On Fri, Jan 05, 2018 at 12:53:28PM -0600, Rob Herring wrote:
> On Thu, Jan 04, 2018 at 03:22:44PM +0800, Chunyan Zhang wrote:

> > +	- regulator-suspend-microvolt: the default voltage which regulator
> > +	  would be set in suspend. The voltage for suspend also can be
> > +	  adjusted among {regulator-suspend-min-microvolt,
> > +	  regulator-suspend-max-microvolt} by calling
> > +	  regulator_set_suspend_voltage(). This property is not deprecated,

> You mean "is deprecated", right?

I suspect "is now" but yeah.

> > +	- regulator-changeable-in-suspend: whether the default voltage and
> > +	  the regulator on/off in suspend can be changed in runtime.

> Is this not implied by having the constraints? Or the driver should know 
> this. The simply means you have some 2nd bank of registers for settings 
> while in suspend mode, right?

No, it means that the software has permission to use those changes to
those registers - we only want to be changing things if the user has
permission to change them since some systems will have specific
constraints, we don't know if it's safe without being explicitly told.
You're right that we could infer this from a range being provided
though, let's do that.

Attachment: signature.asc
Description: PGP signature