RE: [Intel-wired-lan] [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

[Brown, Aaron F]

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On
> Behalf Of Jeff Kirsher
> Sent: Wednesday, December 6, 2017 8:25 AM
> To: Kamble, Sagar A <sagar.a.kamble@xxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: alsa-devel@xxxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; Richard Cochran <richardcochran@xxxxxxxxx>;
> Stephen Boyd <sboyd@xxxxxxxxxxxxxx>; Chris Wilson <chris@chris-
> wilson.co.uk>; John Stultz <john.stultz@xxxxxxxxxx>; intel-wired-
> lan@xxxxxxxxxxxxxxxx; Thomas Gleixner <tglx@xxxxxxxxxxxxx>;
> kvmarm@xxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Intel-wired-lan] [PATCH 1/1] timecounter: Make cyclecounter
> struct part of timecounter struct
> 
> On Sat, 2017-12-02 at 10:01 +0530, Sagar Arun Kamble wrote:
> > There is no real need for the users of timecounters to define
> > cyclecounter
> > and timecounter variables separately. Since timecounter will always
> > be
> > based on cyclecounter, have cyclecounter struct as member of
> > timecounter
> > struct.
> >
> > Suggested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Richard Cochran <richardcochran@xxxxxxxxx>
> > Cc: John Stultz <john.stultz@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
> > Cc: linux-rdma@xxxxxxxxxxxxxxx
> > Cc: alsa-devel@xxxxxxxxxxxxxxxx
> > Cc: kvmarm@xxxxxxxxxxxxxxxxxxxxx
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> 

Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>

> For the changes to the Intel drivers.
> 
> > ---
> >  arch/microblaze/kernel/timer.c                     | 20 ++++++------
> >  drivers/clocksource/arm_arch_timer.c               | 19 ++++++------
> >  drivers/net/ethernet/amd/xgbe/xgbe-dev.c           |  3 +-
> >  drivers/net/ethernet/amd/xgbe/xgbe-ptp.c           |  9 +++---
> >  drivers/net/ethernet/amd/xgbe/xgbe.h               |  1 -
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x.h        |  1 -
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c   | 20 ++++++------
> >  drivers/net/ethernet/freescale/fec.h               |  1 -
> >  drivers/net/ethernet/freescale/fec_ptp.c           | 30 +++++++++---
> > ------
> >  drivers/net/ethernet/intel/e1000e/e1000.h          |  1 -
> >  drivers/net/ethernet/intel/e1000e/netdev.c         | 27 ++++++++--
> > ------
> >  drivers/net/ethernet/intel/e1000e/ptp.c            |  2 +-
> >  drivers/net/ethernet/intel/igb/igb.h               |  1 -
> >  drivers/net/ethernet/intel/igb/igb_ptp.c           | 25 ++++++++--
> > -----
> >  drivers/net/ethernet/intel/ixgbe/ixgbe.h           |  1 -
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c       | 17 +++++-----
> >  drivers/net/ethernet/mellanox/mlx4/en_clock.c      | 28 ++++++++--
> > -------
> >  drivers/net/ethernet/mellanox/mlx4/mlx4_en.h       |  1 -
> >  .../net/ethernet/mellanox/mlx5/core/lib/clock.c    | 34 ++++++++++
> > ----------
> >  drivers/net/ethernet/qlogic/qede/qede_ptp.c        | 20 ++++++------
> >  drivers/net/ethernet/ti/cpts.c                     | 36
> > ++++++++++++----------
> >  drivers/net/ethernet/ti/cpts.h                     |  1 -
> >  include/linux/mlx5/driver.h                        |  1 -
> >  include/linux/timecounter.h                        |  4 +--
> >  include/sound/hdaudio.h                            |  1 -
> >  kernel/time/timecounter.c                          | 28 ++++++++--
> > -------
> >  sound/hda/hdac_stream.c                            |  7 +++--
> >  virt/kvm/arm/arch_timer.c                          |  6 ++--
> >  28 files changed, 163 insertions(+), 182 deletions(-)