Re: [PATCH V4 15/45] block: rename bio_for_each_segment* with bio_for_each_page*

From: Jens Axboe
Date: Sat Jan 06 2018 - 11:19:25 EST


On Mon, Dec 18 2017, Ming Lei wrote:
> It is a tree-wide mechanical replacement since both bio_for_each_segment()
> and bio_for_each_segment_all() never returns real segment at all, and
> both just return one page per bvec and deceive us for long time, so fix
> their names.
>
> This is a pre-patch for supporting multipage bvec. Once multipage bvec
> is in, each bvec will store a real multipage segment, so people won't be
> confused with these wrong names.

No, we're not doing this, it's a pretty pointless tree wide replacement
with a fairly weak justification.

--
Jens Axboe