Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

From: Philippe Ombredanne
Date: Sun Jan 07 2018 - 07:04:44 EST


Knut,

On Fri, Jan 5, 2018 at 3:30 PM, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> On Thu, 04 Jan 2018, Knut Omang <knut.omang@xxxxxxxxxx> wrote:
>> On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote:
>>> On Thu, 04 Jan 2018, Knut Omang <knut.omang@xxxxxxxxxx> wrote:
>>> > Add scripts/runchecks which has generic support for running
>>> > checker tools in a convenient and user friendly way that
>>> > the author hopes can contribute to rein in issues detected
>>> > by these tools in a manageable and convenient way.

<snip>

>>> > --- /dev/null
>>> > +++ b/scripts/runchecks
>>> > @@ -0,0 +1,734 @@
>>> > +#!/usr/bin/python
>>> > +
>>> > +# SPDX-License-Identifier: GPL-2.0

Thank you for using an SPDX tag here .... .

<snip>

>>> > +#
>>> > +# This program is free software; you can redistribute it and/or modify
>>> > +# it under the terms of the GNU General Public License version 2
>>> > +# as published by the Free Software Foundation.
>>> > +

....but then please DRY: do not add this extra legalese which is redundant.

--
Cordially
Philippe Ombredanne