Re: [3/3] GenWQE: Adjust 12 checks for null pointers

From: SF Markus Elfring
Date: Mon Jan 08 2018 - 08:50:24 EST


> I personally like the explicit compare (ptr != NULL) more than the !ptr notation.

Coding style aspects can evolve, can't they?


> When was the checkpatch.pl script modified to suggest the latter notation?

Would you like to take another look at the software update âcheckpatch: add
--strict "pointer comparison to NULL" testâ from 2014-12-10?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b75ac618df751b927469ddbca63cf151a62f0f9d


> Is there any advantage other than the shorter notation?

* Do you eventually care for an influence on the run time characteristics
for the compilation of this software module?

* How do you think about to reduce the dependency on a special preprocessor symbol?

Regards,
Markus