Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support
From: Graeme Gregory
Date: Mon Jan 08 2018 - 10:15:03 EST
On Mon, Jan 08, 2018 at 03:53:12PM +0100, Andrew Lunn wrote:
> On Mon, Jan 08, 2018 at 02:45:48PM +0000, Graeme Gregory wrote:
> > On Thu, Jan 04, 2018 at 05:20:36PM +0100, Andrew Lunn wrote:
> > > > > I already agreed with 'reg' being awkward in the later emails.
> > > > > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus?
> > > > >
> > > > Ah it is an actual address, then yes _ADR is probably more appropriate.
> > >
> > > Newbie ACPI question. What is the definition of an address?
> > >
> > > In this cause, we are talking about an address of a device on an MDIO
> > > bus. It takes a value between 0 and 31.
> > >
> > > How are IC2 device addresses represented in ACPI? MDIO devices and I2C
> > > devices are pretty similar. So it would make sense to use the same as
> > > what I2C uses.
> > >
> > Too big (and has table) to sensibly quote, but defined in ACPI spec
> >
> > 6.1.1 _ADR (Address)
> >
> > Ive never though been quite sure if that is just an example list of
> > address types or its supposed to be canonical (in which case some ECRs
> > are needed to the spec).
>
> Hi Graeme
>
> I took a quick look at version 6.2, and noticed i2c devices use
> _ADR(). So using it for MDIO seems O.K.
>
> However, i2c, spi and uart devices all seem to be described using
> GenericSerialBus. Maybe the correct way to describe MDIO devices is to
> also use GenericSerialBus?
>
I am not familiar with MDIO, but if its similar or a specific
implementation of a serial bus that does sound sane!
Graeme
Attachment:
signature.asc
Description: PGP signature