Re: [RFC] memdup_user() and friends

From: Andy Shevchenko
Date: Mon Jan 08 2018 - 12:26:18 EST


On Sun, Jan 7, 2018 at 4:16 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> What I propose is
> * switch memdup_user() to GFP_USER
> * add vmemdup_user(), using kvmalloc() instead of kmalloc() (also with
> GFP_USER)

Perhaps kvmemdup_user() for sake of consistency?

> * switch open-coded instances of the latter to calling it
> * switch some of the memdup_user() callers to vmemdup_user() - the ones that
> don't need physically contiguous copy and might be larger than a couple of pages.
> * add apriori bounds on size in the call sites that do not have those yet -
> that'll require comments from maintainers of the code in question in some cases.
>
> Objections?

Not at all!

--
With Best Regards,
Andy Shevchenko