Re: [PATCH 4.4 00/22] 4.4.111-stable review

[Greg Kroah-Hartman]

On Mon, Jan 08, 2018 at 03:29:07PM -0800, Guenter Roeck wrote:
> On Mon, Jan 08, 2018 at 01:59:27PM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.4.111 release.
> > There are 22 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed Jan 10 12:59:14 UTC 2018.
> > Anything received after that time might be too late.
> > 
> 
> x86:64:allnoconfig still fails to build.
> 
> To reproduce:
>   make ARCH=x86_64 allnoconfig
>   make ARCH=x86_64 arch/x86/entry/vdso/vma.o
> 
> arch/x86/entry/vdso/vma.c: In function âmap_vdsoâ:
> arch/x86/entry/vdso/vma.c:175:9: error:
> 	implicit declaration of function âpvclock_pvti_cpu0_vaâ
> 
> The function is declared in arch/x86/include/asm/pvclock.h, which is only 
> indirectly included. For 32-bit allnoconfig builds, the include path is:
>   arch/x86/entry/vdso/vma.c
>     include/linux/mm.h
>       ./arch/x86/include/asm/pgtable.h
>         ./arch/x86/include/asm/pgtable_32.h
> 
> but pgtable_64.h doesn't include pgtable_32.h, and the declaration is
> missing as result.

Yeah, I haven't had the chance to work on that yet, sorry.

> The include of asm/pvclock.h was added upstream with commit cc1e24fdb064d
> ("x86/vdso: Remove pvclock fixmap machinery") which applies cleanly to
> v4.4.y. Please consider adding it, or at least add the missing include.

Is it really that easy?  Hey, nice, let me queue that up and test...

thanks,

greg k-h