Re: [PATCH] net: caif: use strlcpy() instead of strncpy()

[David Miller]

From: Xiongfeng Wang <wangxiongfeng2@xxxxxxxxxx>
Date: Mon, 8 Jan 2018 19:43:00 +0800

> From: Xiongfeng Wang <xiongfeng.wang@xxxxxxxxxx>
> 
> gcc-8 reports
> 
> net/caif/caif_dev.c: In function 'caif_enroll_dev':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
> 
> net/caif/cfctrl.c: In function 'cfctrl_linkup_request':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
> 
> net/caif/cfcnfg.c: In function 'caif_connect_client':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 15 bytes from a string of length 15
> [-Wstringop-truncation]
> 
> The compiler require that the input param 'len' of strncpy() should be
> greater than the length of the src string, so that '\0' is copied as
> well. We can just use strlcpy() to avoid this warning.
> 
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@xxxxxxxxxx>

Applied, thank you.