Re: [PATCH v2 1/8] x86/feature: Detect the x86 IBRS feature to control Speculation

[Tim Chen]

On 01/09/2018 02:39 AM, Paolo Bonzini wrote:

> +
> +#define MSR_IA32_SPEC_CTRL		0x00000048
> +#define SPEC_CTRL_FEATURE_DISABLE_IBRS	(0 << 0)
> +#define SPEC_CTRL_FEATURE_ENABLE_IBRS	(1 << 0)


Boris requested that the name for ENABLE/DISABLE to be shortened to
SPEC_CTRL_{ENABLE,DISABLE}_IBRS.  I'm planning to do that
for the next patchset update.

> +
> +#define MSR_IA32_PRED_CMD		0x00000049
> +#define PRED_CMD_IBPB			(1UL << 0)
> +

The IBPB stuff should be enumerated separately.
Feel free to create a separate patch for this chunk.


Thanks.

Tim