Re: [PATCH v2 1/8] x86/feature: Detect the x86 IBRS feature to control Speculation

[Dave Hansen]

On 01/06/2018 04:56 AM, Borislav Petkov wrote:
>> +#define MSR_IA32_SPEC_CTRL		0x00000048
>> +#define SPEC_CTRL_FEATURE_DISABLE_IBRS	(0 << 0)
>> +#define SPEC_CTRL_FEATURE_ENABLE_IBRS	(1 << 0)
> s/_FEATURE//
> 
> SPEC_CTRL_{ENABLE,DISABLE}_IBRS is good enough.

FWIW, I like the idea of including "SPEC_CTRL_" because it matches the
constant to the MSR name.  But I don't care that much.