Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

[Chris Lew]

On 12/21/2017 11:36 AM, Stephen Boyd wrote:
> On 12/20/2017 05:35 PM, Bjorn Andersson wrote:
> > On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote:
> >
> > > On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote:
> > > > Add a label property to identify the edge this node represents.
> > > Why does a user need to know this?
> > We have multiple remoteproc instances, each one having one or more
> > associated SMD or GLINK links (this node), exposing logical
> > communication channels. Some of these logical channels are exposed to
> > user space and we need a way to distinguish them there.
> >
> > In the current implementation of SMD this value goes straight into an
> > sysfs attribute that we can use when writing udev rules and for the DIAG
> > implementation to pair up channels related to the same remoteproc. This
> > adds the equivalent information for glink-backed channels.
> >
> >
> > I'm therefor in favor of picking this patch.
>
> Please add these details to the commit log. Just writing what the patch
> is doing isn't very helpful.

Ok, will do.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project