[PATCH] kmemleak: allow to coexist with fault injection
From: Dmitry Vyukov
Date: Tue Jan 09 2018 - 14:22:55 EST
kmemleak does one slab allocation per user allocation.
So if slab fault injection is enabled to any degree,
kmemleak instantly fails to allocate and turns itself off.
However, it's useful to use kmemleak with fault injection
to find leaks on error paths. On the other hand, checking
kmemleak itself is not so useful because (1) it's a debugging
tool and (2) it has a very regular allocation pattern
(basically a single allocation site, so it either works or not).
Turn off fault injection for kmemleak allocations.
Signed-off-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: linux-mm@xxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
---
mm/kmemleak.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 68648b840e8e..e83987c55a08 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -126,7 +126,7 @@
/* GFP bitmask for kmemleak internal allocations */
#define gfp_kmemleak_mask(gfp) (((gfp) & (GFP_KERNEL | GFP_ATOMIC)) | \
__GFP_NORETRY | __GFP_NOMEMALLOC | \
- __GFP_NOWARN)
+ __GFP_NOWARN | __GFP_NOFAIL)
/* scanning area inside a memory block */
struct kmemleak_scan_area {
--
2.15.1.620.gb9897f4670-goog