Re: [PATCH 2/3] tracing: make sure the parsed string always terminates with '\0'
From: Du, Changbin
Date: Tue Jan 09 2018 - 22:10:28 EST
On Tue, Jan 09, 2018 at 06:02:58PM -0500, Steven Rostedt wrote:
> On Tue, 9 Jan 2018 17:55:47 +0800
> changbin.du@xxxxxxxxx wrote:
>
> > From: Changbin Du <changbin.du@xxxxxxxxx>
> >
> > The parser parse every string into parser.buffer. And some of the callers
> > assume that parser.buffer contains a C string. So it is dangerous that the
> > parser returns a unterminated string. The userspace can leverage this to
> > attack the kernel.
>
> Is this only a bug if we apply your first patch?
>
I don't think so. Seems it is there already.
> -- Steve
>
--
Thanks,
Changbin Du