Re: [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals

[Andy Shevchenko]

On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:
> From: Gayatri Kammela <gayatri.kammela@xxxxxxxxx>
> 
> Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs

 
> +config INTEL_IOMMU_DEBUG
> +	bool "Export Intel IOMMU internals in DebugFS"
> +	depends on INTEL_IOMMU && DEBUG_FS

> +	default n

I thought I commented on this...

Please, remove. "n" is default default, so no need to duplicate it.

> +	help
> +	  IOMMU internal states such as context, PASID tables can be
> seen via
> +	  debugfs. Select this option if you want to export these
> internals.
> +
> +	  Say Y if you need this.

Also I lost a track how this option is being used here. It looks like
this part is not related to the patch itself.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy