Re: [PATCH v6 3/5] iommu/vt-d: Add debugfs support to show register contents

[Andy Shevchenko]

On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:

> Debugfs extension to dump all the register contents for each IOMMU
> device to the user space via debugfs.
> 
> example:
> root@OTC-KBLH-01:~# cat /sys/kernel/debug/intel_iommu/iommu_regset
> 
> DMAR: dmar1: reg_base_addr fed90000
> Name         Offset     Contents
> VER          0x00       0x0000000000000010
> CAP          0x08       0x01c0000c40660462
> ECAP         0x10       0x0000019e2ff0505e
> GCMD         0x18       0x0000000000000000
> GSTS         0x1c       0x00000000c7000000
> RTADDR       0x20       0x00000004558d6800
> CCMD         0x28       0x0800000000000000
> FSTS         0x34       0x0000000000000000
> FECTL        0x38       0x0000000000000000
> FEDATA       0x3c       0xfee0100c00004141

> +		seq_printf(m, "\nDMAR: %s: reg_base_addr %llx\n",
> iommu->name,
> +			   base);

Can we get rid of leading '\n'?

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy