Re: [PATCH v3 3/3] x86/retpoline: Convert generic specific retpolines to use RETPOLINE_GENERIC

[Woodhouse, David]

On Wed, 2018-01-10 at 08:23 -0600, Tom Lendacky wrote:
> On 1/10/2018 7:15 AM, Woodhouse, David wrote:
> > On Tue, 2018-01-09 at 18:28 -0800, Andi Kleen wrote:
> >> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> >>
> >> X86_FEATURE_RETPOLINE has been renamed to X86_FEATURE_RETPOLINE_GENERIC.
> >> Convert the sequences using it.
> >Â
> > AMD documentation says they need the RSB fill too, so these should stay
> > under X86_FEATURE_RETPOLINE I think.
> 
> AMD processors don't fall back to the indirect predictor on an underflow
> so this isn't needed on AMD if it is purely for underflow prevention.

It isn't purely for underflow protection. This is needed (see the AMD
doc) for protecting against RSB entries that actually point to
userspace addresses. It's only not needed if we have SMEP.

Attachment: smime.p7s
Description: S/MIME cryptographic signature