Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

[Boris Brezillon]

Hi Christoph,

On Wed, 10 Jan 2018 16:48:17 +0100
Christoph Hellwig <hch@xxxxxx> wrote:

> On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote:
> > On Wed, 10 Jan 2018 15:15:43 +0000
> > Robin Murphy <robin.murphy@xxxxxxx> wrote:
> >   
> > > phys_to_dma() is an internal helper for certain DMA API implementations,
> > > and is not appropriate for drivers to use. It appears that what the CESA
> > > driver really wants to be using is dma_map_resource() - admittedly that
> > > didn't exist when the offending code was first merged, but it does now.
> > > 
> > > Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>  
> > 
> > Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>  
> 
> Thanks.  Robin, Boris: do you want me to pick this up in the
> dma-mapping tree and move it before the dma-direct.h introduction?

You should probably sync with Herbert, I'm just the maintainer of this
driver, not the crypto subsystem.

Regards,

Boris