Re: [PATCH v2] clk: mediatek: adjust dependency of reset.c to avoid unexpectedly being built
From: Stephen Boyd
Date: Wed Jan 10 2018 - 16:45:29 EST
On 01/05, sean.wang@xxxxxxxxxxxx wrote:
> From: Sean Wang <sean.wang@xxxxxxxxxxxx>
>
> Changes from v1->v2:
> Add 'select RESET_CONTROLLER' under COMMON_CLK_MEDIATEK and enable
> reset.c to be built when COMMON_CLK_MEDIATEK is selected. That should
> be quite reasonable because the reset controller is tightly embedded
> inside and exported from these clock subsystems. At least it can be found
> on infracfg and pericfg subsystem that both are really fundamental block
> lots of devices must depend on.
>
> commit 74cb0d6dde8 ("clk: mediatek: fixup test-building of MediaTek clock
> drivers") can let the build system looking into the directory where the
> clock drivers resides and then allow test-building the drivers.
>
> But the change also gives rise to certain incorrect behavior which is
> reset.c being built even not depending on either COMPILE_TEST or
> ARCH_MEDIATEK alternative dependency. To get rid of reset.c being built
> unexpectedly on the other platforms, it would be a good change that the
> file should be built depending on its own specific configuration rather
> than just on generic RESET_CONTROLLER one.
>
> Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>
> Cc: Jean Delvare <jdelvare@xxxxxxx>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project