Re: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers

[Shuah Khan]

On 01/10/2018 01:40 PM, Jacek Anaszewski wrote:
> Hi Shuah,
> 
> Thanks for the patch.
> 
> On 01/10/2018 05:35 PM, Shuah Khan wrote:
>> Replace GPL license statements with SPDX GPL-2.0 license identifiers
>> and and correct the module license to GPLv2.
>>
>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/leds/trigger/ledtrig-transient.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c
>> index 7acce64b692a..f0578af858e7 100644
>> --- a/drivers/leds/trigger/ledtrig-transient.c
>> +++ b/drivers/leds/trigger/ledtrig-transient.c
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>>  /*
> 
> How about changing this whole block comment to "//"?
> We did it already for drivers/leds/trigger/ledtrig-netdev.c,
> present in linux-next. See related discussion with reference
> to relevant Linus' guidelines in this matter [0].
> 

v2 is on its way.

thanks,
-- Shuah