Re: [PATCH net-next V2 2/2] tuntap: XDP transmission

From: Jason Wang
Date: Wed Jan 10 2018 - 21:35:25 EST




On 2018å01æ11æ 00:11, Tariq Toukan wrote:
+EXPORT_SYMBOL(tun_ptr_to_xdp);
+

Hi Jason,
I started getting the following compilation issues.

+ make -j24 -s
net/socket.o: In function `tun_xdp_to_ptr':
/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46: multiple definition of `tun_xdp_to_ptr'
fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46: first defined here
net/socket.o: In function `tun_ptr_to_xdp':
/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50: multiple definition of `tun_ptr_to_xdp'
fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50: first defined here
make: *** [vmlinux] Error 1

Seems you missed adding the following ifdef:
#if defined(CONFIG_TUN) || defined(CONFIG_TUN_MODULE)

Thanks,
Tariq

My bad and sorry for that.

It should have been fixed by https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=1125b008711581a8962ee028e2982d7757093600

Thanks