Re: [PATCH] [net-next] net: socionext: include linux/io.h to fix build

From: Ard Biesheuvel
Date: Thu Jan 11 2018 - 05:38:37 EST


On 11 January 2018 at 10:36, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> I ran into a randconfig build failure:
>
> drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
> drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]
>
> Including linux/io.h directly fixes this.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for fixing this. This is the same issue spotted by kbuild test robot.

Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

> ---
> drivers/net/ethernet/socionext/netsec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index a8edcf387bba..af47147dd656 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -8,6 +8,7 @@
> #include <linux/of_mdio.h>
> #include <linux/etherdevice.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
>
> #include <net/tcp.h>
> #include <net/ip6_checksum.h>
> --
> 2.9.0
>