Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

[Josh Poimboeuf]

On Thu, Jan 11, 2018 at 09:29:48AM -0800, Linus Torvalds wrote:
> That, btw, is also why it's pointless to make the small numbers
> "bigger". Using "1122" as a label is actively worse than just using
> "1".
> 
> You shouldn't try to fool yourself and think that your number is
> "unique". It doesn't need to be. A label needs to be unique within one
> use, and the use just tells _which_ of the non-unique numbers you use.
> 
> And yes, you could even re-use the number within one macro or inline
> asm. But that's just confusing. Make the number unique for the
> particular macro or inline use.

What if the macro is used by another macro which needs to jump across
it?  If the labels conflict then the outer macro will accidentally jump
to the inner macro.

-- 
Josh