Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

[Jae Hyun Yoo]

On 1/11/2018 2:18 PM, Andrew Lunn wrote:
> > > > > +static const struct of_device_id peci_of_table[] = {
> > > > > +	{ .compatible = "peci-hwmon", },
> > > >
> > > > This does not look like a reference to some piece of hardware.
> > >
> > > This driver provides generic PECI hwmon function to which controller has
> > > PECI HW such as Aspeed or Nuvoton BMC chip so it's not dependant on a
> > > specific hardware. Should I remove this or any suggestion?
>
> PECI seems to be an Intel thing. So at least it should be
>
>   { .compatible = "intel,peci-hwmon", }
>
> assuming it is actually compatible with the Intel specification.
>
> 	 Andrew

Yes, PECI is an Intel thing but this driver is running on an ARM kernel 
on Aspeed or Nuvoton chipsets for now. This driver will be monitoring a 
host server's Intel CPU and DIMM which is running on a separated OS.

Thanks,
Jae