Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

[Stephen Boyd]

On 01/10, Viresh Kumar wrote:
> On 09-01-18, 18:54, Stephen Boyd wrote:
> > My read of Kevin's comments lead me to think he's saying that a
> > generic 'domain-performance-state' property is worse than putting
> > the numbers directly inside of the opp table with a comment above
> > it. Now that's all fine, but now that we have required-opps
> > binding we sort of have the domain-performance-state property
> > again, but it's a phandle instead of a raw state number.
> > 
> > So we have
> > 
> > 	required-opps = <&perf_state>;
> > 
> > but what was proposed before was
> > 
> > 	domain-performance-state = <1>;
> > 
> > or Kevin's 
> > 
> > 	opp-table = <100000 1>;
> 
> His concern was also on what will we do if "frequency" or other OPP
> properties aren't known tomorrow by the kernel but the firmware? In
> Qcom case, its just the voltage (corner) today, but it can very well
> be other properties tomorrow. Are we going to add more platform
> specific bindings then ?

Yes, we would add more bindings.

> And this is the main reason why I have been
> aligned towards using something like this patch.

Once we exceed the number of properties that can fit into the
existing voltage and frequency properties we'll only be able to
make it work by adding a platform specific property. That's one
concern, but it's a future concern so it's not a real problem
yet.

If you can clearly describe in the commit text why we shouldn't
use platform specific properties it would be helpful.

> 
> If we drop the magic-values idea and hence this patch, then we can
> either add a "domain-performance-state" property, which will only be
> used by the power domains or leave it for the platforms to add
> something like "qcom,corner".
> 
> All we are doing here is putting a voltage (corner) value, unknown to
> the kernel, in a new property instead of "opp-microvolt". But the
> above question still remains, what about other properties that may
> need magic values in future.
> 
> Honestly speaking, I am not sure what's the right thing to do here. I
> will do whatever you and Rob incline for.
> 

Hopefully Rob and Kevin can reply here.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project