Re: [PATCH V4 3/8] perf/x86/intel/uncore: correct fixed counter index check in generic code

[Thomas Gleixner]

On Thu, 2 Nov 2017, kan.liang@xxxxxxxxx wrote:

> From: Kan Liang <Kan.liang@xxxxxxxxx>
> 
> There is no index which is bigger than UNCORE_PMC_IDX_FIXED. The only
> exception is client IMC uncore. It has customized function to deal with
> the 'UNCORE_PMC_IDX_FIXED + 1' case. It does not touch the generic code.
> For generic code, it is not correct to use >= to check fixed counter.
> The code quality issue will bring problem when new counter index is
> introduced.
> 
> Signed-off-by: Kan Liang <Kan.liang@xxxxxxxxx>

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>