Re: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for free running counter

From: Thomas Gleixner
Date: Sun Jan 14 2018 - 15:52:32 EST


On Thu, 2 Nov 2017, kan.liang@xxxxxxxxx wrote:

> From: Kan Liang <Kan.liang@xxxxxxxxx>
>
> The free running counter is read-only and always active. Current generic
> uncore code does not support this kind of counters.
>
> The free running counter is read-only. It cannot be enable/disable in
> event_start/stop.
> The free running counter event and free running counter are 1:1 mapped.
> It doesn't need to be assigned nor tracked by event_list.
> The free running counters are always active. It doesn't need to check
> the free running counters' availability.
>
> Use inline helpers to check fixed counter index and free running counter
> index.
>

That changelog is horrible to read. Other than that:

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>