Re: [PATCH] ARM: dts: s5pv210: add interrupt-parent for ohci
From: Arnd Bergmann
Date: Mon Jan 15 2018 - 08:00:49 EST
On Thu, Jan 11, 2018 at 9:09 AM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On Wed, Jan 10, 2018 at 5:10 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> The ohci-hcd node has an interrupt number but no interrupt-parent,
>> leading to a warning with current dtc versions:
>>
>> arch/arm/boot/dts/s5pv210-aquila.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-goni.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-smdkc110.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-smdkv210.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>> arch/arm/boot/dts/s5pv210-torbreck.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/ohci@ec300000
>>
>> As seen from the related exynos dts files, the ohci and ehci controllers
>> always share one interrupt number, and the number is the same here as
>> well, so setting the same interrupt-parent is the reasonable solution
>> here.
>
> Your patch is correct. However my last pull request still waits and it
> is quite late in this release cycle so I will apply it for v4.17 after
> this merge window. On the other hand you can take it directly (in that
> case: Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>).
Applied to next/dt, thanks!
Arnd